Issue 1112 ec sei params #1136
Merged
Issue 1112 ec sei params #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtimms
commented
Sep 4, 2020
|
|
||
| c_e_typ = self.param.c_e_typ | ||
| L_x = self.param.L_x | ||
|
|
There was a problem hiding this comment.
should this be epsilon * c_e here?
There was a problem hiding this comment.
Looks good, but I think there should be a better way to do #1112 .
Also, there are some .pkl files in examples/notebooks to remove. They should probably be removed when running the notebooks (using os.remove)
|
|
||
| c_e_typ = self.param.c_e_typ | ||
| L_x = self.param.L_x | ||
|
|
| @@ -131,3 +111,48 @@ def set_initial_conditions(self, variables): | |||
| j_sei_0 = pybamm.Scalar(0) | |||
|
|
|||
| self.initial_conditions = {L_sei: L_sei_0, j_sei: j_sei_0} | |||
|
|
|||
| def _get_standard_concentraion_variables(self, variables): | |||
There was a problem hiding this comment.
If this function is only ever called from get_coupled_variables, there is no need to make it a separate function. Ideally, we should find a way to make it use the method from base_sei (e.g. with inner set to 0 and outer representing the total)
There was a problem hiding this comment.
yep, makes sense. will change now, thanks
valentinsulzer
approved these changes
Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #1112 and #1117
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: